Updated README.md to reflect sha256 deprecation in favor of `identi…#43
Open
CallVoidStar wants to merge 1 commit intogroob:masterfrom
Open
Updated README.md to reflect sha256 deprecation in favor of `identi…#43CallVoidStar wants to merge 1 commit intogroob:masterfrom
sha256 deprecation in favor of `identi…#43CallVoidStar wants to merge 1 commit intogroob:masterfrom
Conversation
…fier` in configuration I configured moroz with a binary rule following the `README.md` I pasted the sha256 from the block event into my config: ``` [[rules]] rule_type = "BINARY" policy = "ALLOWLIST" sha256 = "<snip>" ``` I received an error on a Santa client after running `santactl sync`: ``` Ignoring bad rule: policy: ALLOWLIST rule_type: BINARY received 100 rules processed 99 rules ``` After digging into why `sha256` wasn't working and was actively rejected by Santa clients, I found this line of code in Santa project that deprecates `sha256` in favor of the term `identifier`: https://github.com/google/santa/blob/261425aa64bd49523ef99845dab04797da4fa614/Source/santasyncservice/syncv1.proto#L293 Using `identifier` instead fixed my issue. This change updates `README.md` to save others from having to track this down too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I configured moroz with a binary rule following the current examples in
README.md. I pasted the sha256 from the block event into my config:I received an error on a Santa client after running
santactl sync:After digging into why
sha256wasn't working and was actively rejected by Santa clients, I found this line of code in Santa project that deprecatessha256in favor of the termidentifier:https://github.com/google/santa/blob/261425aa64bd49523ef99845dab04797da4fa614/Source/santasyncservice/syncv1.proto#L293
Using
identifierinstead fixed my issue. This change updatesREADME.mdto save others from having to track this down too.